[lkml]   [2010]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PWM PATCH 3/5] Expunge old Atmel PWMC driver, replacing it with one that conforms to the PWM API
H Hartley Sweeten wrote:
> You have a couple name changes here, were they intentional?
> Filename: atmel_pwm.c -> atmel-pwm.c
> Driver name: atmel_pwm -> atmel_pwmc
> Module alias: platform:atmel_pwm -> platform:atmel_pwmc

Yes. In the datasheet, the peripheral is called the "PWMC" and so
that's why the driver name changed. For consistency, I guess I should
have named the file atmel-pwmc.c as well. Finally, I find it easier to
type file names with dashes rather than underscores. :)

> Also, will this new driver still work for all the existing users of
> the old one? Are there any platform changes that need to be done?

There are platform changes necessary, to register and use the devices.
The driver API is different from the previous code, so there are changes
there as well. Functionally, however, the new stuff is a superset of
what the previous driver provided.


Bill Gatliff

 \ /
  Last update: 2010-02-03 05:13    [W:0.188 / U:10.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site