Messages in this thread | | | Subject | Re: [PATCH] seastar - SeaStar Ethernet driver (review comments addressed) | From | Joe Perches <> | Date | Tue, 02 Feb 2010 18:02:01 -0800 |
| |
On Tue, 2010-02-02 at 18:08 -0700, Kevin Pedretti wrote: > diff -uprN -X linux-2.6.32.7-vanilla/Documentation/dontdiff linux-2.6.32.7-vanilla/drivers/net/seastar/main.c linux-2.6.32.7/drivers/net/seastar/main.c > --- linux-2.6.32.7-vanilla/drivers/net/seastar/main.c 1969-12-31 17:00:00.000000000 -0700 > +++ linux-2.6.32.7/drivers/net/seastar/main.c 2010-02-02 17:52:31.000000000 -0700 [] > +static struct pending *alloc_tx_pending(struct ss_priv *ssp) > +{ > + struct pending *pending = ssp->tx_pending_free_list; > + if (!pending) > + return NULL; > + > + ssp->tx_pending_free_list = pending->next; > + pending->next = 0;
kernel style doesn't like pointer assignments of 0. NULL is preferred.
> + /* Squash broadcast packets, SeaStar doesn't support broadcast */ > + if (dest_lo_mac == 0xFF) { > + dev_err(&ssp->pdev->dev, "squashing broadcast packet."); > + return -1; > + }
Presumably SeaStar doesn't support multicast either, so maybe: if (dest_low_mac & 0x01)
| |