lkml.org 
[lkml]   [2010]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/6] generic sys_old_select
On Mon, Feb 01, 2010 at 11:40:29PM +0100, Andreas Schwab wrote:
> > Index: linux-2.6/fs/compat.c
> > ===================================================================
> > --- linux-2.6.orig/fs/compat.c 2010-01-12 14:08:16.202003005 +0100
> > +++ linux-2.6/fs/compat.c 2010-01-29 23:35:20.187003404 +0100
> > @@ -1795,6 +1795,24 @@ asmlinkage long compat_sys_select(int n,
> > return ret;
> > }
> >
> > +struct compat_sel_arg_struct {
> > + compat_ulong_t n;
> > + compat_ulong_t inp;
> > + compat_ulong_t outp;
> > + compat_ulong_t exp;
> > + compat_ulong_t tvp;
> > +};
>
> Shouldn't the last four be compat_uptr_t?

Strictly speaking yes, although it doesn't matter for the generated
code. The patch below makes it use the strictly correct type:


Index: linux-2.6/fs/compat.c
===================================================================
--- linux-2.6.orig/fs/compat.c 2010-02-02 09:20:16.207003623 +0100
+++ linux-2.6/fs/compat.c 2010-02-02 09:20:53.554012789 +0100
@@ -1797,10 +1797,10 @@ asmlinkage long compat_sys_select(int n,

struct compat_sel_arg_struct {
compat_ulong_t n;
- compat_ulong_t inp;
- compat_ulong_t outp;
- compat_ulong_t exp;
- compat_ulong_t tvp;
+ compat_uptr_t inp;
+ compat_uptr_t outp;
+ compat_uptr_t exp;
+ compat_uptr_t tvp;
};

asmlinkage long compat_sys_old_select(struct compat_sel_arg_struct __user *arg)


\
 
 \ /
  Last update: 2010-02-02 09:39    [W:0.068 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site