lkml.org 
[lkml]   [2010]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 5/7] ext3: use nofail variant of inode_setattr()
Date
After we updated i_disk_size and stop the journal it is
too late for error handling from inode_setattr().
Since inode_change_ok() is now responsible for all
necessery checks we may call __inode_setattr() which can
not fail.

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext3/inode.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 455e6e6..196aee3 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -3184,8 +3184,11 @@ int ext3_setattr(struct dentry *dentry, struct iattr *attr)
error = rc;
ext3_journal_stop(handle);
}
-
- rc = inode_setattr(inode, attr);
+ /*
+ * All necessery check already done in inode_check_ok(),
+ * it is safe to use nofail version here.
+ */
+ __inode_setattr(inode, attr);

if (!rc && (ia_valid & ATTR_MODE))
rc = ext3_acl_chmod(inode);
--
1.6.6


\
 
 \ /
  Last update: 2010-02-19 20:53    [from the cache]
©2003-2011 Jasper Spaans