lkml.org 
[lkml]   [2010]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 11/12] drivers: isdn: use new hex_to_bin() method
    Am 18.02.2010 19:55 schrieb Andy Shevchenko:
    > From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
    >
    > Get rid of own implementation of hex_to_bin(). It requires to have hex_to_bin()
    > introduced by one of previous path in series.
    >
    > Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
    > ---
    > drivers/isdn/gigaset/capi.c | 14 ++------------
    > 1 files changed, 2 insertions(+), 12 deletions(-)
    >
    > diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
    > index 83c4e2f..72adcfb 100644
    > --- a/drivers/isdn/gigaset/capi.c
    > +++ b/drivers/isdn/gigaset/capi.c
    > @@ -13,6 +13,7 @@
    >
    > #include "gigaset.h"
    > #include <linux/ctype.h>
    > +#include <linux/kernel.h>
    > #include <linux/isdn/capilli.h>
    > #include <linux/isdn/capicmd.h>
    > #include <linux/isdn/capiutil.h>

    You don't need to include kernel.h here, it's already included
    from gigaset.h.

    > @@ -169,17 +170,6 @@ static inline void ignore_cstruct_param(struct cardstate *cs, _cstruct param,
    > }
    >
    > /*
    > - * convert hex to binary
    > - */
    > -static inline u8 hex2bin(char c)
    > -{
    > - int result = c & 0x0f;
    > - if (c & 0x40)
    > - result += 9;
    > - return result;
    > -}
    > -
    > -/*
    > * convert an IE from Gigaset hex string to ETSI binary representation
    > * including length byte
    > * return value: result length, -1 on error
    > @@ -190,7 +180,7 @@ static int encode_ie(char *in, u8 *out, int maxlen)
    > while (*in) {
    > if (!isxdigit(in[0]) || !isxdigit(in[1]) || l >= maxlen)
    > return -1;
    > - out[++l] = (hex2bin(in[0]) << 4) + hex2bin(in[1]);
    > + out[++l] = (hex_to_bin(in[0]) << 4) + hex_to_bin(in[1]);
    > in += 2;
    > }
    > out[0] = l;

    Otherwise, fine with me.

    Thanks,
    Tilman

    --
    Tilman Schmidt E-Mail: tilman@imap.cc
    Bonn, Germany
    Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
    Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-02-19 00:59    [from the cache]
    ©2003-2011 Jasper Spaans