Messages in this thread | | | Subject | Re: printk_ratelimited() not compiling | From | john stultz <> | Date | Thu, 18 Feb 2010 15:49:15 -0800 |
| |
On Thu, 2010-02-18 at 15:33 -0800, john stultz wrote: > On Thu, 2010-02-18 at 15:23 -0800, Joe Perches wrote: > > On Thu, 2010-02-18 at 14:36 -0800, john stultz wrote: > > > > Am I missing something obvious, or did something get broken after this went in? > > > Ok. Solved it. I needed to #include <linux/ratelimit.h> in the file I > > > was adding the printk_ratelimited usage in, rather then where > > > printk_ratelimited is defined. > > > > > > Maybe would it be better to move the printk_ratelimited definitions into > > > ratelimit.h so this would be more obvious? > > > > That's one option. > > > > Probably the only places I tried it had an > > #include <linux/net.h> somewhere which does an > > #include <linux/ratelimit.h> > > > > Personally, I think it'd be better to put > > #include <linux/ratelimit.h> back in kernel.h > > Commit 3fff4c42bd0a89869a0eb1e7874cc06ffa4aa0f5 removed it. > > Right, that's what I tried first, but it doesn't build. :) > > If ratelimit.h has to be included for it to work (which is fine by me), > it seems ratelimit.h would be the ideal place to define it. > > CC'ing Peter to see what his thoughts are.
Sorry, that should have been Ingo I cc'ed. Peter didn't make that change.
thanks -john
| |