lkml.org 
[lkml]   [2010]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge
    Hi Mike,

    On Wed, Feb 17, 2010 at 02:35:30PM +0200, Mike Rapoport wrote:
    > Samuel,
    >
    > Jean Delvare wrote:
    > > On Wed, 17 Feb 2010 12:03:17 +0200, Denis Turischev wrote:
    > >> Jean Delvare wrote:
    > >>> Might be a good idea to use acpi_check_resource_conflict() or similar
    > >>> before instantiating the platform devices.
    > >> May be it worth to add such resource check directly to mfd_add_device function?
    > >
    > > I'm not sure. I suspect that many MFD devices are never used on
    > > ACPI-aware systems, so it might be considered overkill. OTOH the calls
    > > resolve to empty stubs when ACPI is disabled so... I have no objection,
    > > but I'll leave the decision to somebody else ;)
    > >
    >
    > What do you think? Shall we add something like mfd_verify_resources that will call
    > acpi_check_region or something similar?
    Yes, that sounds like a reasonable idea. We should probably call
    acpi_check_resource_conflict() straight from mfd_add_device(). I'll do that,
    no need for Denis to add that patch for its code to be merged.

    Cheers,
    Samuel.


    >
    > --
    > Sincerely yours,
    > Mike.

    --
    Intel Open Source Technology Centre
    http://oss.intel.com/


    \
     
     \ /
      Last update: 2010-02-17 15:39    [W:0.024 / U:61.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site