lkml.org 
[lkml]   [2010]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/38] KVM: VMX: Remove emulation failure report
    Date
    From: Sheng Yang <sheng@linux.intel.com>

    As Avi noted:

    >There are two problems with the kernel failure report. First, it
    >doesn't report enough data - registers, surrounding instructions, etc.
    >that are needed to explain what is going on. Second, it can flood
    >dmesg, which is a pretty bad thing to do.

    So we remove the emulation failure report in handle_invalid_guest_state(),
    and would inspected the guest using userspace tool in the future.

    Signed-off-by: Sheng Yang <sheng@linux.intel.com>
    Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
    ---
    arch/x86/kvm/vmx.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
    index fc1964d..516084f 100644
    --- a/arch/x86/kvm/vmx.c
    +++ b/arch/x86/kvm/vmx.c
    @@ -3449,7 +3449,6 @@ static int handle_invalid_guest_state(struct kvm_vcpu *vcpu)
    }

    if (err != EMULATE_DONE) {
    - kvm_report_emulation_failure(vcpu, "emulation failure");
    vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
    vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_EMULATION;
    vcpu->run->internal.ndata = 0;
    --
    1.6.5.3


    \
     
     \ /
      Last update: 2010-02-16 11:37    [W:0.022 / U:29.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site