Messages in this thread Patch in this message | | | From | Serge Hallyn <> | Subject | [PATCH 8/8] p9auth: don't trim entries on write-only open | Date | Tue, 16 Feb 2010 16:45:01 -0600 |
| |
From: Serge E. Hallyn <serue@us.ibm.com>
If we want to support an admin clearing all entries, let's not do it through some subtle hidden channel, but rather implement a 'CLEAR' command to /dev/caphash, which requires privilege to use.
Signed-off-by: Serge E. Hallyn <serue@us.ibm.com> Cc: Greg KH <greg@kroah.com> cc: rsc@swtch.com Cc: Ashwin Ganti <ashwin.ganti@gmail.com> Cc: ericvh@gmail.com Cc: devel@linuxdriverproject.org Cc: linux-kernel@vger.kernel.org Cc: Ron Minnich <rminnich@gmail.com> --- drivers/staging/p9auth/p9auth.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/p9auth/p9auth.c b/drivers/staging/p9auth/p9auth.c index 6012bd9..06128c3 100644 --- a/drivers/staging/p9auth/p9auth.c +++ b/drivers/staging/p9auth/p9auth.c @@ -146,13 +146,6 @@ static int cap_open(struct inode *inode, struct file *filp) dev = container_of(inode->i_cdev, struct cap_dev, cdev); filp->private_data = dev; - /* trim to 0 the length of the device if open was write-only */ - if ((filp->f_flags & O_ACCMODE) == O_WRONLY) { - if (down_interruptible(&dev->sem)) - return -ERESTARTSYS; - cap_trim(dev); - up(&dev->sem); - } /* initialise the head if it is NULL */ if (dev->head == NULL) { dev->head = kmalloc(sizeof(struct cap_node), GFP_KERNEL); -- 1.6.1
| |