lkml.org 
[lkml]   [2010]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v1 0/4] CFS Bandwidth Control
On Fri, Feb 12, 2010 at 06:54:52PM -0800, Paul Turner wrote:
> Todo:
> -----
> - hierarchal nr_tasks_running accounting:
> This is a deficiency currently shared with SCHED_RT rate limiting. When
> entities is throttled the running tasks it owns are not subtracted from
> rq->nr_running. This then results in us missing idle_balance() due to
> phantom tasks and load balancer weight per task calculations being
> incorrect.
>
> This code adds complexity which was both increasing the complexity of the
> initial review for this patchset and truly probably best reviewed
> independently of this feature's scope. To that end we'll post a separate
> patch for this issue against the current RT rate-limiting code and merge any
> converged on approach here as appropriate.

I had tried updating rq->nr_running in my v2 patchset
(http://lkml.org/lkml/2009/9/30/117, http://lkml.org/lkml/2009/9/30/119)
But since I felt that it added a lot of complexity, I removed it
subsequently in v3 (http://lkml.org/lkml/2009/11/9/65) and kept it similar
to RT.

>
> - throttle statistics:
> Some statistics regarding the frequency and duration of throttling
> definitely in order.

Please take a look at some of the throttling related stats I am collecting
in my patchset.

Regards,
Bharata.



\
 
 \ /
  Last update: 2010-02-16 07:21    [from the cache]
©2003-2011 Jasper Spaans