lkml.org 
[lkml]   [2010]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: bug list: range checking issues
On Tue, 16 Feb 2010, Clemens Ladisch wrote:

> This looks correct; the channels parameter is an interval, not a mask.
>
> if (!params->fifo_size) {
> if (snd_mask_min(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT]) ==
> snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT]) &&
> snd_mask_min(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS]) ==
> snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) {
>
> Jaroslav, I guess this should have been snd_interval_min/max?
> And shouldn't the parameters be accessed with hw_param_mask/interval?

Yes, the checks are not valid. Thanks for this notice. I fixed this issue
in this commit:

http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=3be522a9514f58e0596db34898a514df206cadc5

Jaroslav

-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.



\
 
 \ /
  Last update: 2010-02-16 12:05    [W:1.338 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site