Messages in this thread | | | Date | Sun, 14 Feb 2010 22:24:46 -0800 (PST) | Subject | Re: [PATCH -mm] ssb: open-code dma_alloc_coherent | From | David Miller <> |
| |
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Date: Mon, 15 Feb 2010 14:21:58 +0900
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> > Subject: [PATCH -mm] ssb: open-code dma_alloc_coherent > > This removes ssb_dma_alloc_consistent, a wrapper for > dma_alloc_coherent and pci_alloc_consistent. dma_alloc_coherent > internally calls pci_alloc_consistent against pci devices so we always > use dma_alloc_coherent. > > I prefer to use the DMA API directly instead of creating the ssb_dma_ > API. We have been removing any bus specific DMA APIs. > > One disadvantage of this approach that we lost the debugging ability > of checking the buggy usage of the DMA API against non DMA-capable ssb > buses. But I guess that the ssb drivers are mature enough and can cope > with such change? > > I plan to replace all the ssb_dma API if this approach is fine. > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
I'm fine with this:
Acked-by: David S. Miller <davem@davemloft.net>
| |