lkml.org 
[lkml]   [2010]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH tip/core/rcu 05/13] net: add checking to rcu_dereference() primitives

    * Eric Dumazet <eric.dumazet@gmail.com> wrote:

    > Le jeudi 11 f??vrier 2010 ?? 16:00 -0800, Paul E. McKenney a ??crit :
    > > Update rcu_dereference() primitives to use new lockdep-based checking.
    > > The rcu_dereference() in __in6_dev_get() may be protected either by
    > > rcu_read_lock() or RTNL, per Eric Dumazet. The rcu_dereference()
    > > in __sk_free() is protected by the fact that it is never reached if an
    > > update could change it. Check for this by using rcu_dereference_check()
    > > to verify that the struct sock's ->sk_wmem_alloc counter is zero.
    > >
    > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    >
    > CC to netdev and David Miller, network maintainer.
    >
    > Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
    >
    > Thanks Paul, great work !

    Dave, does this look good to you too? Cannot pick up the rest of the patchset
    without these checks/annotations into the RCU tree as there's too many
    warnings triggering in the networking code. So it's an all-or-nothing
    patchset in that regard.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2010-02-14 09:27    [W:0.021 / U:91.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site