lkml.org 
[lkml]   [2010]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v3 2/2] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET
    On 02/11, Roland McGrath wrote:
    >
    > > +static int ptrace_regset(struct task_struct *task, int req, unsigned int type,
    > > + struct iovec *kiov)
    > > +{
    > > + const struct user_regset_view *view = task_user_regset_view(task);
    > > + const struct user_regset *regset = find_regset(view, type);
    > > + int regset_no;
    > > +
    > > + if (!regset || (kiov->iov_len % regset->size) != 0)
    > > + return -EIO;
    >
    > My inclination would be to diagnose these more specifically.

    Agreed.

    Otherwise I think the patch is fine.

    Oleg.



    \
     
     \ /
      Last update: 2010-02-12 17:03    [W:0.022 / U:0.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site