lkml.org 
[lkml]   [2010]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 -mm 01/14] adds include/linux/pci-dma.h
    On Wed, Feb 10, 2010 at 10:34:34AM +0900, FUJITA Tomonori wrote:
    > This patch adds include/linux/pci-dma.h that defines the pci_unmap
    > state API:
    >
    > DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)
    > DECLARE_PCI_UNMAP_LEN(LEN_NAME)
    > pci_unmap_addr(PTR, ADDR_NAME)
    > pci_unmap_addr_set(PTR, ADDR_NAME, VAL)
    > pci_unmap_len(PTR, LEN_NAME)
    > pci_unmap_len_set(PTR, LEN_NAME, VAL)
    >
    > This enables us to remove lots of the duplication in architecture
    > implementations since there are only two ways to define the API.
    >
    > If architectures define CONFIG_NEED_DMA_MAP_STATE, they get the real
    > definition of pci_unmap state API. If not, they get the noop
    > definition.
    >
    > In the long term, it's better to replace the API with the generic
    > device model API such as DECLARE_DMA_UNMAP_ADDR. We can map the API to
    > the generic one (like dma-mapping-compat.h does). This patch also
    > makes the migration process easier. We can remove this file after the
    > migration.
    >
    > It might be simpler to add the API to include/linux/pci.h but looks
    > it's already too large. We'll remove pci-dma.h after finishing moving
    > to the generic device model. So I put the API to a separate file.
    >
    > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

    Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>


    \
     
     \ /
      Last update: 2010-02-12 15:55    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean