[lkml]   [2010]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] [1/4] SLAB: Handle node-not-up case in fallback_alloc() v2
    On Thu, Feb 11, 2010 at 01:41:53PM -0800, David Rientjes wrote:
    > On Thu, 11 Feb 2010, Andi Kleen wrote:
    > > When fallback_alloc() runs the node of the CPU might not be initialized yet.
    > > Handle this case by allocating in another node.
    > >
    > > v2: Try to allocate from all nodes (David Rientjes)
    > >
    > You don't need to specifically address the cpuset restriction in
    > fallback_alloc() since kmem_getpages() will return NULL whenever a zone is
    > tried from an unallowed node, I just thought it was a faster optimization
    > considering you (i) would operate over a nodemask and not the entire
    > zonelist, (ii) it would avoid the zone_to_nid() for all zones since you
    > already did a zonelist iteration in this function, and (iii) it wouldn't
    > needlessly call kmem_getpages() for unallowed nodes.

    Thanks for the review again.

    I don't really care about performance at all for this, this is just for
    a few allocations during the memory hotadd path.


    -- -- Speaking for myself only.

     \ /
      Last update: 2010-02-11 22:57    [W:0.020 / U:4.028 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site