lkml.org 
[lkml]   [2010]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [4/4] SLAB: Fix node add timer race in cache_reap
    Date

    cache_reap can run before the node is set up and then reference a NULL
    l3 list. Check for this explicitely and just continue. The node
    will be eventually set up.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    mm/slab.c | 3 +++
    1 file changed, 3 insertions(+)

    Index: linux-2.6.32-memhotadd/mm/slab.c
    ===================================================================
    --- linux-2.6.32-memhotadd.orig/mm/slab.c
    +++ linux-2.6.32-memhotadd/mm/slab.c
    @@ -4093,6 +4093,9 @@ static void cache_reap(struct work_struc
    * we can do some work if the lock was obtained.
    */
    l3 = searchp->nodelists[node];
    + /* Note node yet set up */
    + if (!l3)
    + break;

    reap_alien(searchp, l3);


    \
     
     \ /
      Last update: 2010-02-11 21:57    [W:0.019 / U:1.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site