Messages in this thread | | | Subject | Re: [PATCH 2/6] DMFE: move pci ID definitions into pci_ids.h and clean up the code | From | Maxim Levitsky <> | Date | Thu, 11 Feb 2010 19:25:22 +0200 |
| |
On Wed, 2010-02-10 at 13:22 -0800, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Wed, 10 Feb 2010 13:18:49 -0800 (PST) > > > From: Maxim Levitsky <maximlevitsky@gmail.com> > > Date: Sat, 6 Feb 2010 22:18:58 +0200 > > > >> Signed-off-by: Maxim Levitsky <maxim-levitsky@gmail.com> > > > > We don't add new definitions to pci_ids.h that will only > > be used in a single driver. No problem! Didn't know about that.
> > > > Instead, we just use the raw constants (if it's only referenced once, > > say in the PCI ID table for the driver) or using local definitions > > (if used multiple times in the driver). > > BTW, the rest of your patch set is likely to not apply > correctly after you fix this patch up. So at a minimum > you'll need to resubmit this whole set after fixing > patch #2. I agree with that completely.
> > In fact I would recommend that you seperate the bug > fixes from all of the massive cleanups. > > Get the bug fixes, especially the PCI READ MULTIPLE > disable one, into net-2.6 > > Then afterwards you can do all of the cleanups against > net-next-2.6 when the bug fixes propagate there. This is good idea too. I also will split the cleanups, because looking back at massive patch I understand that it is not good for review.
> > Thank you!
Thanks too.
Best regards, Maxim Levitsky
| |