Messages in this thread | | | Date | Thu, 11 Feb 2010 18:08:05 +0300 | From | Evgeniy Polyakov <> | Subject | Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs |
| |
On Thu, Feb 11, 2010 at 03:02:54AM +0000, Al Viro (viro@ZenIV.linux.org.uk) wrote: > Um. You do realize that d_move() happens with none of your locks held, > right? It's done in vfs_rename_{other,dir}() and the only thing held > is s_vfs_rename_sem and i_mutex on parents. How could your code in > writeback be able to distinguish
No, it happens with my lock held. It is not a lock, but kind of IO delegation, i.e. it is not dropped when rename or other protected operation completed. Instead another client sends request to grab it and server asks current holder to drop cache, perform writeback or whatever else is needed.
It can be a problem though if d_move() is called outside of path protected by the VFS dir operations like rename/created/unlink and so on, i.e. on behalf of some entity in the kernel which decides to move dentries on itself. In this case POHMELFS is not protected.
-- Evgeniy Polyakov
| |