lkml.org 
[lkml]   [2010]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC][PATCH] Allow change timing values to wait slow devices bring up before try register an interface to IP-Config

On Wed, 10 Feb 2010 03:47:59 +0000 Tiago Maluta <tiago.maluta@gmail.com> wrote:
>
>

Please cc netdev@vger.kernel.org on net patches - linux-net@vger is not
used for development.

> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index dd9a09c..12fbe4a 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -38,6 +38,24 @@ config IFB
> 'ifb1' etc.
> Look at the iproute2 documentation directory for usage etc
>
> +config NETDEVICES_DELAY_PRE_OPEN
> + int "Define the delay before opening net devices (ms)"
> + depends on NETDEVICES
> + default 500
> + help
> + Some devices may not work properly due to a delay from hardware bring
> + the interface up. This value add a delay, in miilliseconds, before

typo.

> + kernel search and register the interface. Default value is 500ms.
> +
> +config NETDEVICES_DELAY_POST_OPEN
> + int "Define the delay after opening net devices (s)"
> + depends on NETDEVICES
> + default 1
> + help
> + Some devices may not work properly due to a delay from hardware bring
> + the interface up. This value add a delay, in seconds, after
> + kernel search and register the interface. Default value is 1s.
> +
> config DUMMY
> tristate "Dummy net driver support"
> ---help---
> diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
> index 10a6a60..2530126 100644
> --- a/net/ipv4/ipconfig.c
> +++ b/net/ipv4/ipconfig.c
> @@ -86,8 +86,8 @@
> #endif
>
> /* Define the friendly delay before and after opening net devices */
> -#define CONF_PRE_OPEN 500 /* Before opening: 1/2 second */
> -#define CONF_POST_OPEN 1 /* After opening: 1 second */
> +#define CONF_PRE_OPEN CONFIG_NETDEVICES_DELAY_PRE_OPEN /* Before
> opening. Default is 1/2 second */
> +#define CONF_POST_OPEN CONFIG_NETDEVICES_DELAY_POST_OPEN /* After
> opening. Default is 1 second */

Your email client wordwrapped this.

Using delays was dumb of us, but I guess the problem is difficult.

It would be much better to configure this delay at runtime rather than
at compile time. Perhaps with new kernel boot parameters, perhaps by
extending the ip= argument.




\
 
 \ /
  Last update: 2010-02-10 06:53    [W:0.029 / U:5.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site