lkml.org 
[lkml]   [2010]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/35] x86: print out for RAM buffer
On 02/09/2010 11:52 AM, Andrew Morton wrote:
>>
>> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
>> index a966b75..dfb1689 100644
>> --- a/arch/x86/kernel/e820.c
>> +++ b/arch/x86/kernel/e820.c
>> @@ -1429,6 +1429,9 @@ void __init e820_reserve_resources_late(void)
>> end = MAX_RESOURCE_SIZE;
>> if (start >= end)
>> continue;
>> + printk(KERN_DEBUG "reserve RAM buffer: %016Lx - %016Lx ",
>> + (unsigned long long) start,
>> + (unsigned long long) end);
>> reserve_region_with_split(&iomem_resource, start, end,
>> "RAM buffer");
>> }
>
> The typecasts for printing u64's are unneeded within x86 code. In fact
> I think they're now unneeded on all architectures.
>

... not to mention that the proper printf format for long long is "ll".
"L" is used for long double, although a lot of implementations treat
"L" and "ll" the same.

And yes, it's a nitpick.

-hpa


\
 
 \ /
  Last update: 2010-02-10 22:23    [W:0.054 / U:4.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site