[lkml]   [2010]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 02/11] tracing: Introduce TRACE_EVENT_INJECT
On Wed, 2010-02-10 at 11:04 +0100, Frederic Weisbecker wrote:

> > We can add a register_event_injector later. For now, why not just add
> > the TRACE_EVENT() and then hook to it in perf using the normal
> > tracepoint mechanism.
> >
> > You could add some macro around the trace_init_lock_class() call that
> > would facilitate finding all the locks you need. This would probably be
> > a bit more straight forward than to overload TRACE_EVENT() again.
> I'm not sure what you mean by that.

Looking back at where trace_lock_class_init() was placed, you don't need
a wrapper. But instead, why not just have perf hook directly into the
trace_lock_class_init trace point, and do its injection directly.
Instead of needing to add some hack to TRACE_EVENT()?

-- Steve

 \ /
  Last update: 2010-02-10 15:07    [W:0.072 / U:1.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site