lkml.org 
[lkml]   [2010]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] irda: remove BKL from irnet open function
    Date
    Commit cddf63d99d0d145f18b293c3d0de4af7dab2a922 has push down the BKL
    into irnet open function. However, there's nothing that needs locking in
    there.

    Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
    ---
    net/irda/irnet/irnet_ppp.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)

    diff --git a/net/irda/irnet/irnet_ppp.c b/net/irda/irnet/irnet_ppp.c
    index 156020d..d6b502c 100644
    --- a/net/irda/irnet/irnet_ppp.c
    +++ b/net/irda/irnet/irnet_ppp.c
    @@ -479,7 +479,6 @@ dev_irnet_open(struct inode * inode,
    ap = kzalloc(sizeof(*ap), GFP_KERNEL);
    DABORT(ap == NULL, -ENOMEM, FS_ERROR, "Can't allocate struct irnet...\n");

    - lock_kernel();
    /* initialize the irnet structure */
    ap->file = file;

    @@ -501,7 +500,6 @@ dev_irnet_open(struct inode * inode,
    {
    DERROR(FS_ERROR, "Can't setup IrDA link...\n");
    kfree(ap);
    - unlock_kernel();
    return err;
    }

    @@ -512,7 +510,6 @@ dev_irnet_open(struct inode * inode,
    file->private_data = ap;

    DEXIT(FS_TRACE, " - ap=0x%p\n", ap);
    - unlock_kernel();
    return 0;
    }

    --
    1.6.6.1


    \
     
     \ /
      Last update: 2010-02-01 19:25    [W:0.020 / U:0.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site