Messages in this thread | | | Date | Fri, 10 Dec 2010 00:16:28 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] coda: kill redundant cast in coda_alloc_inode() |
| |
On Thu, 9 Dec 2010, Jesper Juhl wrote:
> kmem_cache_alloc() returns a void pointer which there is no need to cast. > > Signed-off-by: Jesper Juhl <jj@chaosbits.net> > --- > inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/coda/inode.c b/fs/coda/inode.c > index 5ea57c8..1a49c17 100644 > --- a/fs/coda/inode.c > +++ b/fs/coda/inode.c > @@ -45,7 +45,7 @@ static struct kmem_cache * coda_inode_cachep; > static struct inode *coda_alloc_inode(struct super_block *sb) > { > struct coda_inode_info *ei; > - ei = (struct coda_inode_info *)kmem_cache_alloc(coda_inode_cachep, GFP_KERNEL); > + ei = kmem_cache_alloc(coda_inode_cachep, GFP_KERNEL); > if (!ei) > return NULL; > memset(&ei->c_fid, 0, sizeof(struct CodaFid));
Applied, thanks Jesper.
-- Jiri Kosina SUSE Labs, Novell Inc.
| |