lkml.org 
[lkml]   [2010]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/16] x86: Remove custom apic->cpu_to_logical_apicid() implementations
    On Sat, 27 Nov 2010, Tejun Heo wrote:

    > After the previous patch, apic->cpu_to_logical_apicid() is no longer
    > used. The callback will be repurposed. Remove all the custom

    That's a very bad idea. You remove the callbacks from the esoteric
    platforms, but you keep the other implementation in the tree.

    It's not longer used now, so remove all incarnations and get rid of
    all those useless = NULL initializations at the same time. Then
    implement a new callback with a different name.

    It's slightly more work and code churn, but it makes the change
    entirely clear. It'd be also nice to annotate in the function name
    that this is 32bit only or even make it 32bit dependent if it's not
    too much ifdeffery

    Thanks,

    tglx



    \
     
     \ /
      Last update: 2010-12-09 22:31    [W:0.020 / U:122.956 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site