lkml.org 
[lkml]   [2010]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 0/2 v1] Ioctl for reading block queue information
From
Date
On 2010-12-09, at 12:20, Greg KH wrote:
> On Thu, Dec 09, 2010 at 04:25:35PM +0100, Lukas Czerner wrote:
>> For a long time it has been pretty painful to retrieve informations from
>> /sys/block/*/queue for particular block device. Not only it is painful
>> to retrieve informations within C tool, parsing strings, etc, but one
>> have to run into problem even finding the proper path in sysfs.
>
> What's wrong with using libudev? That should give you all of this
> information easily using a .c program without any need to change the
> kernel at all.
>
> Ick, no, please just use the sysfs files, don't create a new ioctl, they
> are horrid.

Can you please show a real example of how using libudev is less horrid than just calling "ioctl(fd, BLKGETQUEUEINFO, &val)"?

How is trying to map a block device name from /etc/mtab (via getmntent()) into a possibly wildly different block device name in /sys (e.g. /dev/vgroot/lvhome vs. /dev/dm-0 vs. /dev/mapper/vgroot-lvhome => /sys/block/dm-0), then parsing text output considered a "good API"?

Cheers, Andreas







\
 
 \ /
  Last update: 2010-12-09 20:51    [W:0.867 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site