lkml.org 
[lkml]   [2010]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] e1000e: cleanup: swap arguments to avoid checkpatch errors
On Thu, 09 Dec 2010 03:32:28 +0000
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote:
> > Swap argument order in order to avoid checkpatch treating it as an
> > unary operation, instead of an binary one, and obtain consistency
> > with the 3 other similar assignments in netdev.c (tdlen & rdlen).
> >
> > This patch fixes 3 checkpatch errors.
>
> You have got to be kidding. If the checkpatch warning offends you, fix
> the bug in checkpatch instead of changing perfectly good code.
>
> Ben.

That bug is fixed already:
https://patchwork.kernel.org/patch/299172/

Andrew picked it up.

Regards,
Flo


\
 
 \ /
  Last update: 2010-12-09 11:37    [from the cache]
©2003-2011 Jasper Spaans