lkml.org 
[lkml]   [2010]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] syslog: check cap_syslog when dmesg_restrict
From
Date
On Wed, 2010-12-08 at 16:42 +0000, Serge E. Hallyn wrote:
> Quoting Eric Paris (eparis@redhat.com):
> > I think the code might be
> > incorrect today as well......
> >
> > I thought the flow was supposed to be
> >
> > if (capable(CAP_SYSLOG))
> > all good
> > else if (capable(CAP_SYS_ADMIN))
> > WARN, but still good for now
>
> I prefer warn and deny. Otherwise it's too easy to ignore warnings. So
> I prefer the msg to be there to explain why it failed - not that I expect
> it to fail for anyone today.

Ok, fine with me.

Acked-by: Eric Paris <eparis@redhat.com>



\
 
 \ /
  Last update: 2010-12-08 17:49    [from the cache]
©2003-2011 Jasper Spaans