Messages in this thread | | | Date | Wed, 8 Dec 2010 11:15:56 -0500 | From | Jarod Wilson <> | Subject | Re: [PATCH v2] media: rc: ir-lirc-codec: fix integer overflow |
| |
On Sun, Dec 05, 2010 at 12:05:22AM +0300, Vasiliy Kulikov wrote: > 'n' may be bigger than MAX_INT*sizeof(int), if so checking of truncated > (int)(n/sizeof(int)) for LIRCBUF_SIZE overflows and then using nontruncated 'count' > doesn't make sense. This is not a security issue as too big 'n' is catched in > kmalloc() in memdup_user() call. However, it's better to prevent WARN() in kmalloc(). > > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Now that I have my head out of my arse wrt the actual issue here, the redundancy issue from v1 is resolved, and I've managed a full night's sleep... ;)
Acked-by: Jarod Wilson <jarod@redhat.com>
-- Jarod Wilson jarod@redhat.com
| |