lkml.org 
[lkml]   [2010]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 5/6] msm: hotplug: support cpu hotplug on msm
    On Tue, Dec 07, 2010 at 08:28:20PM -0800, Jeff Ohlstein wrote:
    > +static DECLARE_COMPLETION(cpu_killed);

    There's changes in my tree for 2.6.38 which gets rid of this completion
    from platform code.

    > +void platform_cpu_die(unsigned int cpu)
    > +{
    > +#ifdef DEBUG
    > + unsigned int this_cpu = hard_smp_processor_id();
    > +
    > + if (cpu != this_cpu) {
    > + printk(KERN_CRIT "Eek! platform_cpu_die running on %u, should be %u\n",
    > + this_cpu, cpu);
    > + BUG();
    > + }
    > +#endif

    This debug check can not possibly ever happen; it can be removed.

    > +
    > + printk(KERN_NOTICE "CPU%u: shutdown\n", cpu);

    This printk is not required with those changes I mentioned above.



    \
     
     \ /
      Last update: 2010-12-08 16:19    [W:0.019 / U:0.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site