lkml.org 
[lkml]   [2010]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1.5 5/5] keys: add new key-type encrypted
Date
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> > > +static struct key *request_trusted_key(const char *trusted_desc,
> > > + u8 **master_key,
> > > + unsigned int *master_keylen)
> >
> > You need to annotate the function with an __acquires() to indicate that it
> > returns with a lock held for Sparse checking. I think you should be able to
> > do:
> >
> > __acquires(tkey->sem)
>
> hm, only after addding '__acquires' are there Sparse errors.

Leave it, then.

David


\
 
 \ /
  Last update: 2010-12-08 11:57    [W:0.460 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site