Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v1.5 5/5] keys: add new key-type encrypted | Date | Wed, 08 Dec 2010 10:54:24 +0000 |
| |
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > > +static struct key *request_trusted_key(const char *trusted_desc, > > > + u8 **master_key, > > > + unsigned int *master_keylen) > > > > You need to annotate the function with an __acquires() to indicate that it > > returns with a lock held for Sparse checking. I think you should be able to > > do: > > > > __acquires(tkey->sem) > > hm, only after addding '__acquires' are there Sparse errors.
Leave it, then.
David
| |