lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[067/127] usb: misc: sisusbvga: fix information leak to userland
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Vasiliy Kulikov <segooon@gmail.com>

    commit 5dc92cf1d0b4b0debbd2e333b83f9746c103533d upstream.

    Structure sisusb_info is copied to userland with "sisusb_reserved" field
    uninitialized. It leads to leaking of contents of kernel stack memory.

    Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/misc/sisusbvga/sisusb.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/misc/sisusbvga/sisusb.c
    +++ b/drivers/usb/misc/sisusbvga/sisusb.c
    @@ -3008,6 +3008,7 @@ sisusb_ioctl(struct file *file, unsigned
    #else
    x.sisusb_conactive = 0;
    #endif
    + memset(x.sisusb_reserved, 0, sizeof(x.sisusb_reserved));

    if (copy_to_user((void __user *)arg, &x, sizeof(x)))
    retval = -EFAULT;



    \
     
     \ /
      Last update: 2010-12-08 03:09    [W:0.026 / U:91.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site