lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[073/127] USB: misc: cypress_cy7c63: fix up some sysfs attribute permissions
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Greg Kroah-Hartman <gregkh@suse.de>

    commit c990600d340641150f7270470a64bd99a5c0b225 upstream.

    They should not be writable by any user.

    Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oliver Bock <bock@tfh-berlin.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/misc/cypress_cy7c63.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    --- a/drivers/usb/misc/cypress_cy7c63.c
    +++ b/drivers/usb/misc/cypress_cy7c63.c
    @@ -195,11 +195,9 @@ static ssize_t get_port1_handler(struct
    return read_port(dev, attr, buf, 1, CYPRESS_READ_PORT_ID1);
    }

    -static DEVICE_ATTR(port0, S_IWUGO | S_IRUGO,
    - get_port0_handler, set_port0_handler);
    +static DEVICE_ATTR(port0, S_IRUGO | S_IWUSR, get_port0_handler, set_port0_handler);

    -static DEVICE_ATTR(port1, S_IWUGO | S_IRUGO,
    - get_port1_handler, set_port1_handler);
    +static DEVICE_ATTR(port1, S_IRUGO | S_IWUSR, get_port1_handler, set_port1_handler);


    static int cypress_probe(struct usb_interface *interface,



    \
     
     \ /
      Last update: 2010-12-08 03:09    [W:0.019 / U:10.364 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site