lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[214/289] USB: misc: usbsevseg: fix up some sysfs attribute permissions
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Greg Kroah-Hartman <gregkh@suse.de>

    commit e24d7ace4e822debcb78386bf279c9aba4d7fbd1 upstream.

    They should not be writable by any user.

    Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Harrison Metzger <harrisonmetz@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/misc/usbsevseg.c | 10 ++++------
    1 file changed, 4 insertions(+), 6 deletions(-)

    --- a/drivers/usb/misc/usbsevseg.c
    +++ b/drivers/usb/misc/usbsevseg.c
    @@ -192,7 +192,7 @@ static ssize_t set_attr_##name(struct de
    \
    return count; \
    } \
    -static DEVICE_ATTR(name, S_IWUGO | S_IRUGO, show_attr_##name, set_attr_##name);
    +static DEVICE_ATTR(name, S_IRUGO | S_IWUSR, show_attr_##name, set_attr_##name);

    static ssize_t show_attr_text(struct device *dev,
    struct device_attribute *attr, char *buf)
    @@ -223,7 +223,7 @@ static ssize_t set_attr_text(struct devi
    return count;
    }

    -static DEVICE_ATTR(text, S_IWUGO | S_IRUGO, show_attr_text, set_attr_text);
    +static DEVICE_ATTR(text, S_IRUGO | S_IWUSR, show_attr_text, set_attr_text);

    static ssize_t show_attr_decimals(struct device *dev,
    struct device_attribute *attr, char *buf)
    @@ -272,8 +272,7 @@ static ssize_t set_attr_decimals(struct
    return count;
    }

    -static DEVICE_ATTR(decimals, S_IWUGO | S_IRUGO,
    - show_attr_decimals, set_attr_decimals);
    +static DEVICE_ATTR(decimals, S_IRUGO | S_IWUSR, show_attr_decimals, set_attr_decimals);

    static ssize_t show_attr_textmode(struct device *dev,
    struct device_attribute *attr, char *buf)
    @@ -319,8 +318,7 @@ static ssize_t set_attr_textmode(struct
    return -EINVAL;
    }

    -static DEVICE_ATTR(textmode, S_IWUGO | S_IRUGO,
    - show_attr_textmode, set_attr_textmode);
    +static DEVICE_ATTR(textmode, S_IRUGO | S_IWUSR, show_attr_textmode, set_attr_textmode);


    MYDEV_ATTR_SIMPLE_UNSIGNED(powered, update_display_powered);



    \
     
     \ /
      Last update: 2010-12-08 02:21    [W:4.566 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site