lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[230/289] cifs: fix parsing of hostname in dfs referrals
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jeff Layton <jlayton@redhat.com>

    commit ba03864872691c0bb580a7fb47388da337ef4aa2 upstream.

    The DFS referral parsing code does a memchr() call to find the '\\'
    delimiter that separates the hostname in the referral UNC from the
    sharename. It then uses that value to set the length of the hostname via
    pointer subtraction. Instead of subtracting the start of the hostname
    however, it subtracts the start of the UNC, which causes the code to
    pass in a hostname length that is 2 bytes too long.

    Regression introduced in commit 1a4240f4.

    Reported-and-Tested-by: Robbert Kouprie <robbert@exx.nl>
    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Cc: Wang Lei <wang840925@gmail.com>
    Cc: David Howells <dhowells@redhat.com>
    Signed-off-by: Steve French <sfrench@us.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/cifs/dns_resolve.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/cifs/dns_resolve.c
    +++ b/fs/cifs/dns_resolve.c
    @@ -66,7 +66,7 @@ dns_resolve_server_name_to_ip(const char
    /* Search for server name delimiter */
    sep = memchr(hostname, '\\', len);
    if (sep)
    - len = sep - unc;
    + len = sep - hostname;
    else
    cFYI(1, "%s: probably server name is whole unc: %s",
    __func__, unc);



    \
     
     \ /
      Last update: 2010-12-08 02:19    [W:4.177 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site