lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[231/289] ath9k: fix timeout on stopping rx dma
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Felix Fietkau <nbd@openwrt.org>

    commit d47844a014fada1a788719f6426bc7044f2a0fd8 upstream.

    It seems that using ath9k_hw_stoppcurecv to stop rx dma is not enough.
    When it's time to stop DMA, the PCU is still busy, so the rx enable
    bit never clears.
    Using ath9k_hw_abortpcurecv helps with getting rx stopped much faster,
    with this change, I cannot reproduce the rx stop related WARN_ON anymore.

    Signed-off-by: Felix Fietkau <nbd@openwrt.org>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/wireless/ath/ath9k/recv.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/ath/ath9k/recv.c
    +++ b/drivers/net/wireless/ath/ath9k/recv.c
    @@ -508,7 +508,7 @@ bool ath_stoprecv(struct ath_softc *sc)
    bool stopped;

    spin_lock_bh(&sc->rx.rxbuflock);
    - ath9k_hw_stoppcurecv(ah);
    + ath9k_hw_abortpcurecv(ah);
    ath9k_hw_setrxfilter(ah, 0);
    stopped = ath9k_hw_stopdmarecv(ah);




    \
     
     \ /
      Last update: 2010-12-08 02:17    [W:3.050 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site