lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] user_ns: Improve the user_ns on-the-slab packaging
On Tue, 07 Dec 2010 17:12:33 +0300
Pavel Emelyanov <xemul@parallels.com> wrote:

> @@ -126,3 +128,11 @@ gid_t user_ns_map_gid(struct user_namespace *to, const struct cred *cred, gid_t
> /* No useful relationship so no mapping */
> return overflowgid;
> }
> +
> +static __init int user_namespaces_init(void)
> +{
> + user_ns_cachep = KMEM_CACHE(user_namespace, SLAB_PANIC);
> + return 0;
> +}
> +
> +__initcall(user_namespaces_init);

checkpatch (which you apparently didn't use) says

WARNING: please use device_initcall() instead of __initcall()
#81: FILE: kernel/user_namespace.c:138:
+__initcall(user_namespaces_init);

which was a somewhat random recommendation. I think I'll switch it to
plain old module_init().

Presumably user-namespaces don't get used prior to initcalls being run.



\
 
 \ /
  Last update: 2010-12-07 23:15    [W:1.216 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site