Messages in this thread | | | Date | Tue, 07 Dec 2010 17:14:33 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller |
| |
At Wed, 24 Nov 2010 23:04:25 +0100, Wolfram Sang wrote: > > On Wed, Nov 24, 2010 at 12:29:57PM +0100, Takashi Iwai wrote: > > At Wed, 24 Nov 2010 10:59:35 +0100, > > Wolfram Sang wrote: > > > > > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > > > > > > > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */ > > > > +#define SDHCI_QUIRK_MMC_VDD_180 (1<<30) > > > > > > Can't we handle this more generic? Like setting ocr_avail_* from > > > sdhci-pci.c somehow (just brainstorming, didn't have a deeper look)? I'd > > > like to avoid new quirks as much as possible. > > > > OK, what about the one below? > > Looks better to me. (sadly, still from a glimpse, no thorough review)
Chris, any chance to take a look at this?
thanks,
Takashi
| |