Messages in this thread | | | Date | Tue, 07 Dec 2010 21:17:19 +0530 | From | Trilok Soni <> | Subject | Re: [RFC v1 PATCH 3/6] led: pmic8058: Add PMIC8058 leds driver |
| |
Hi Peter,
>>>> >>>> If max_brightness is hardcoded in the driver you can reuse "struct led_info" and >>>> "struct struct led_platform_data" instead of adding your own structs. >>> >> >> I couldn't remove these pmic8058_led structure due to the "enum pmic8058_led id" member >> info which I need from every led. This can be removed completely only if I abuse >> the "flags" parameter in struct led_info to pass the led id. Let me know what you think. > > Hi > > I think that would be ok, other drivers seem to do the same.
Thanks. I will use "flags" parameter for "id" then and submit the re-worked version as V2.
---Trilok Soni
-- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |