lkml.org 
[lkml]   [2010]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] msm: timer: SMP timer support for msm
On Mon, Dec 06, 2010 at 10:56:14AM +0100, Thomas Gleixner wrote:
> > + local_irq_save(flags);
> > + get_irq_chip(clock->irq.irq)->unmask(clock->irq.irq);
>
> Why are you fiddling wiht the irqchip functions directly ? Please use
> disable_irq/enable_irq if at all.

PPI. The interrupt has to be enabled by the very same CPU that wants
to receive the interrupt. Other CPUs on the system do not have access
to the interrupt enable bits for PPIs.

That's something which genirq can't handle because it doesn't _actually_
support real per-CPU interrupts - iow, ones which are truely private to
CPU N.

Eg, if IRQ 29 is the local timer interrupt, then CPU0 has its own IRQ29
which is distinctly different - and has separate enable registers and
ultimately different timer hardware - from CPU1's IRQ29.

On the other SMP platforms, these interrupts aren't handled by genirq,
but we do control them via code like the above (which I'm about to kill
off and move that detail into gic.c.)


\
 
 \ /
  Last update: 2010-12-06 11:23    [from the cache]
©2003-2011 Jasper Spaans