lkml.org 
[lkml]   [2010]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
* Vasiliy Kulikov <segoon@openwall.com> [101126 08:56]:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile this driver, so it is not tested at all.

Thanks will merge this.

Tony

>
> arch/arm/plat-omap/counter_32k.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
> index 155fe43..c1e0d00 100644
> --- a/arch/arm/plat-omap/counter_32k.c
> +++ b/arch/arm/plat-omap/counter_32k.c
> @@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
> return -ENODEV;
>
> sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
> - if (sync_32k_ick)
> + if (!IS_ERR(sync_32k_ick))
> clk_enable(sync_32k_ick);
>
> clocksource_32k.mult = clocksource_hz2mult(32768,
> --
> 1.7.0.4
>


\
 
 \ /
  Last update: 2010-12-07 00:55    [from the cache]
©2003-2011 Jasper Spaans