Messages in this thread | | | Date | Mon, 6 Dec 2010 12:44:23 -0800 | From | Jesse Barnes <> | Subject | Re: [patch 1/4] vt-d: quirk for masking vtd spec errors to platform error handling logic |
| |
On Mon, 06 Dec 2010 12:26:30 -0800 Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> On Mon, 2010-12-06 at 09:27 -0800, Jesse Barnes wrote: > > Can we make these registers and bits a bit more self-documenting (i.e. > > #defines for both, maybe along with other useful bit definitions for > > this reg)? Also, "error" is misspelled as "erorr" above. :) > > Thanks for the review. Appended the updated patch. I haven't used > #defines for the pci-id's, as the first one (IOH) is used by several > chipsets and the second one is not named yet.
Is there a bug # that should be referenced in the commit log? Any tested-bys to add?
Thanks, -- Jesse Barnes, Intel Open Source Technology Center
| |