lkml.org 
[lkml]   [2010]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [thisops uV3 14/18] lguest: Use this_cpu_ops
    Date
    On Wed, 1 Dec 2010 05:37:21 am Christoph Lameter wrote:
    > Use this_cpu_ops in a couple of places in lguest.
    >
    > Cc: Rusty Russell <rusty@rustcorp.com.au>
    > Signed-off-by: Christoph Lameter <cl@linux.com>

    This doesn't even compile :(

    I've applied it, and applied the following fixes, too:

    lguest: compile fixes

    arch/x86/lguest/boot.c: In function ‘lguest_init_IRQ’:
    arch/x86/lguest/boot.c:824: error: macro "__this_cpu_write" requires 2 arguments, but only 1 given
    arch/x86/lguest/boot.c:824: error: ‘__this_cpu_write’ undeclared (first use in this function)
    arch/x86/lguest/boot.c:824: error: (Each undeclared identifier is reported only once
    arch/x86/lguest/boot.c:824: error: for each function it appears in.)

    drivers/lguest/x86/core.c: In function ‘copy_in_guest_info’:
    drivers/lguest/x86/core.c:94: error: lvalue required as left operand of assignment

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

    diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
    --- a/arch/x86/lguest/boot.c
    +++ b/arch/x86/lguest/boot.c
    @@ -821,7 +821,7 @@ static void __init lguest_init_IRQ(void)

    for (i = FIRST_EXTERNAL_VECTOR; i < NR_VECTORS; i++) {
    /* Some systems map "vectors" to interrupts weirdly. Not us! */
    - __this_cpu_write(vector_irq[i]) = i - FIRST_EXTERNAL_VECTOR;
    + __this_cpu_write(vector_irq[i], i - FIRST_EXTERNAL_VECTOR);
    if (i != SYSCALL_VECTOR)
    set_intr_gate(i, interrupt[i - FIRST_EXTERNAL_VECTOR]);
    }
    diff --git a/drivers/lguest/x86/core.c b/drivers/lguest/x86/core.c
    --- a/drivers/lguest/x86/core.c
    +++ b/drivers/lguest/x86/core.c
    @@ -91,7 +91,7 @@ static void copy_in_guest_info(struct lg
    * Guest has changed.
    */
    if (__this_cpu_read(lg_last_cpu) != cpu || cpu->last_pages != pages) {
    - __this_cpu_read(lg_last_cpu) = cpu;
    + __this_cpu_write(lg_last_cpu, cpu);
    cpu->last_pages = pages;
    cpu->changed = CHANGED_ALL;
    }
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2010-12-06 08:49    [W:0.022 / U:61.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site