lkml.org 
[lkml]   [2010]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[Use cpuops V1 08/11] Fakekey: Simplify speakup_fake_key_pressed through this_cpu_ops
    The whole function can be expressed as a simple this_cpu_read() operation.
    The function overhead is now likely multiple times that of the single
    instruction that is executed in it.

    Cc: William Hubbs <w.d.hubbs@gmail.com>
    Signed-off-by: Christoph Lameter <cl@linux.com>

    ---
    drivers/staging/speakup/fakekey.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    Index: linux-2.6/drivers/staging/speakup/fakekey.c
    ===================================================================
    --- linux-2.6.orig/drivers/staging/speakup/fakekey.c 2010-11-30 12:10:12.000000000 -0600
    +++ linux-2.6/drivers/staging/speakup/fakekey.c 2010-11-30 12:14:12.000000000 -0600
    @@ -96,10 +96,5 @@ void speakup_fake_down_arrow(void)
    */
    bool speakup_fake_key_pressed(void)
    {
    - bool is_pressed;
    -
    - is_pressed = get_cpu_var(reporting_keystroke);
    - put_cpu_var(reporting_keystroke);
    -
    - return is_pressed;
    + return this_cpu_read(reporting_keystroke);
    }


    \
     
     \ /
      Last update: 2010-12-06 18:19    [W:0.020 / U:59.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site