lkml.org 
[lkml]   [2010]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] perf_event: fix error handling path
From
On Sun, Dec 5, 2010 at 8:29 PM, Thiago Farina <tfransosi@gmail.com> wrote:
>
> On Sat, Dec 4, 2010 at 1:19 AM,  <bookjovi@gmail.com> wrote:
> > fix error handling path
> >
> > Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
> >  kernel/perf_event.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> > index cb6c0d2..62f9e9d 100644
> > --- a/kernel/perf_event.c
> > +++ b/kernel/perf_event.c
> > @@ -1918,8 +1918,6 @@ static int get_callchain_buffers(void)
> >        }
> >
> >        err = alloc_callchain_buffers();
> > -       if (err)
> > -               release_callchain_buffers();
>
> Care to explain in the change log message? As I reader, is not clear
> to me what is wrong with this.

Sorry, the description should be as:
fix error handling path. alloc_callchain_buffers() can return -ENOMEM,
in this time callchain_cpus_entries maybe is NULL, It will oops if
invoke release_callchain_buffers() when callchain_cpus_entries is
NULL.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-12-06 03:01    [W:0.249 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site