Messages in this thread | | | Date | Mon, 6 Dec 2010 09:40:46 +1100 (EST) | From | James Morris <> | Subject | Re: VS: [PATCH] Smack: label for task objects (retry 2) |
| |
On Fri, 3 Dec 2010, Eric Paris wrote:
> 2) If #1 is true and you want to get Sign-off's in your parent tree > you can set up the child trees as a remote. Then you can use: > > git format-patch -k --stdout HEAD..remotes/[child]/[branch] | git am > -3 -k --whitespace=fix -s
I don't think this is the right approach. If you're pulling from a repo, then your signoff does not go on each patch because you trust the repo.
Otherwise, you should actually be reviewing each patch, which the above is not doing.
> Our tree is so simple I don't really understand why we need all this, > but if we need it, lets figure out what works best for everyone!
Each LSM maintainer should probably be doing per-patch review of the patches going into their tree, and adding their signoff, while I will try and always just do pulls from those trees.
-- James Morris <jmorris@namei.org>
| |