lkml.org 
[lkml]   [2010]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] vsprintf: Add %pMbt, bluetooth mac address
    From
    2010/12/4 Joe Perches <joe@perches.com>:
    > Bluetooth output the MAC address in reverse order.
    > Bluetooth memory order: 00 01 02 03 04 05 is output "05:04:03:02:01:00".
    >
    > This can save overall text when bluetooth is compiled in.
    >
    > Bluetooth currently uses a very slightly unsafe local function (batostr)
    > to output these formatted addresses.
    >
    > Adding %pMbt allows the batostr function to be removed.

    Just a nitpick:
    You could call it %pMR, as in 'Reverse', so it sounds better when/if
    some other subsystem uses it. It would also be a hint of what is this
    doing instead of where it came from.

    Best Regards,
    Michał Mirosław
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-12-04 12:07    [W:0.028 / U:2.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site