lkml.org 
[lkml]   [2010]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATVH] media, dvb, IX2505V: Remember to free allocated memory in failure path (ix2505v_attach()).
    Hi,

    We may leak the storage allocated to 'state' in
    drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error.
    This patch makes sure we free the allocated memory in the failure case.


    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    ---
    ix2505v.c | 1 +
    1 file changed, 1 insertion(+)

    Compile tested only.

    diff --git a/drivers/media/dvb/frontends/ix2505v.c b/drivers/media/dvb/frontends/ix2505v.c
    index 55f2eba..fcb173d 100644
    --- a/drivers/media/dvb/frontends/ix2505v.c
    +++ b/drivers/media/dvb/frontends/ix2505v.c
    @@ -293,6 +293,7 @@ struct dvb_frontend *ix2505v_attach(struct dvb_frontend *fe,
    ret = ix2505v_read_status_reg(state);

    if (ret & 0x80) {
    + kfree(state);
    deb_i2c("%s: No IX2505V found\n", __func__);
    goto error;
    }


    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2010-12-31 00:23    [W:0.021 / U:90.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site