lkml.org 
[lkml]   [2010]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Proposal to add dynamic debug feature for print_hex_dump [2/2]
From
Date
On Fri, 2010-12-03 at 15:21 +0100, Roman Fietze wrote:
> Subject: [PATCH 2/2] dynamic printk: add support for pr_debug_hex_dump
> Use dynamic printk wrapper to support turning pr_debug_hex_dump on and
> off similar to pr_debug using the dynamic debug sysfs control file.
>
> Signed-off-by: Roman Fietze <roman.fietze@telemotive.de>
[]
> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> index a90b389..0610e74 100644
> @@ -74,6 +74,24 @@ do_printk: \
> out: ; \
> } while (0)
>
> +#define dynamic_pr_hex_dump(prfx_str, prfx_type, rowsz, grpsz, \
> + buf, len, ascii) \

I think this should be dynamic_pr_debug_hex_dump and
I think the arguments should be:

#define dynamic_pr_debug_hex_dump(prefix_str, prefix_type, \
rowsize, groupsize, buf, len, ascii) \

to mirror the print_hex_dump args.

> +#define dynamic_pr_hex_dump(prfx_str, prfx_type, rowsz, grpsz, \
> + buf, len, ascii) \
> + do { if (0) print_hex_dump(KERN_DEBUG, prfx_str, prfx_type, rowsz, grpsz, \
> + buf, len, ascii); } while (0)
> #endif

here too.

But because this doesn't fit sensibly on a single line,
perhaps this should now be:

#define dynamic_pr_debug_hex_dump(prefix_str, prefix_type, \
rowsize, groupsize, buf, len, ascii) \
{ \
if (0) \
print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, \
rowsize, groupsize, buf, len, ascii); \
}
> @@ -230,13 +226,25 @@ extern void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
> #if defined(DEBUG)
> #define pr_debug(fmt, ...) \
> printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
> +#define pr_debug_hex_dump(prfx_str, prfx_type, rowsz, grpsz, \
> + buf, len, ascii) \
> + print_hex_dump(KERN_DEBUG, prfx_str, prfx_type, rowsz, grpsz, \
> + buf, len, ascii)

Please use the same argument names as print_hex_dump




\
 
 \ /
  Last update: 2010-12-03 21:39    [from the cache]
©2003-2011 Jasper Spaans