lkml.org 
[lkml]   [2010]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 1/2 v2] tracing: Add TRACE_EVENT_CONDITIONAL()
From
Date
On Fri, 2010-12-03 at 10:27 -0500, Mathieu Desnoyers wrote:

> > > TP_CONDITION(unlikely(someparam)),
> >
> > I actually think this is an abuse of "unlikely".
>
> Why are you considering this an abuse ?

Because it is overused. I would rather get rid of most unlikely()'s
because they are mostly meaningless. Just run the unlikely profiler, and
you will see a large number of them are just plain incorrect.

Adding them here probably doesn't do any good. The only reason for this
TP_CONDITION() is to ignore those cases that it just does not make sense
to trace. Like a wake up tracepoint that does not wake anything up. No
need for "unlikely" or "likely", by trying to do that, you will most
likely get it wrong.

unlikely(use_likely_correctly)


-- Steve




\
 
 \ /
  Last update: 2010-12-03 16:41    [W:0.075 / U:0.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site